Closed
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
Author
|
NOTE: The CI will be broken because we are commenting out a lot of code, which will be fixed in another tickets |
alexvuong
commented
May 12, 2025
| "@types/react": "~18.2.0", | ||
| "@types/react-dom": "~18.2.1", | ||
| "@types/react-router-dom": "~5.3.3", | ||
| "@peculiar/webcrypto": "^1.4.2", |
Contributor
Author
There was a problem hiding this comment.
TODO: Keep this set up until we are ready to merge this upgrade to next branch
…ui-upgrade-v3-toasts @W-18602313 Chakra V3 Upgrade - toast
…age_gallery_upgrade
…antity_picker_upgrade
…ery/index.jsx Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Signed-off-by: Ben Chypak <bchypak@mobify.com>
…hub.com/SalesforceCommerceCloud/pwa-kit into bendvc/W-18672066_image_gallery_upgrade
…66_image_gallery_upgrade [Chakra V3 Upgrade 🎨] Update `ImageGallery` Component @@W-18672066@@
…antity_picker_upgrade
…66_quantity_picker_upgrade [Chakra V3 Upgrade 🎨] Update QuantityPicker Component @@W-18682956@@
* Upgrade Breadcrumb component * Add test page * Remove breadcrumb test page
…eckout-confirmation-page
Migrate Account Details Page to use Chakra V3
…25_checkout-confirmation-page [ChakraV3 Upgrade] ♻️ Checkout Confirmation Page @@W-18913525@@
* upgrade page designer comps with chakra v3
* migrate and enable wishlist page * [Chakra V3 Upgrade] @W-18672916 refactor Wishlist page components (#2768) * migrate wishlist secondary button group * migrate wishlist primary action * migrate useDisclosure hook * comment out failing tests * add back button hover style * use prependHandlersToServer in jest-setup to simplify server setup * wrap user action in act to avoid React warning * skip commented tests to track them * fix confirmation modal header style * fix loading state for useWishlist hook * center the text for empty wishlist/order history pages * simplify code with Flex * use string number for gap * fix perttier issue * Update packages/extension-chakra-storefront/src/pages/account/wishlist/index.jsx Co-authored-by: Alex Vuong <alex.vuong@salesforce.com> Signed-off-by: sf-jie-dai <jie.dai@salesforce.com> * fix perttier issue --------- Signed-off-by: sf-jie-dai <jie.dai@salesforce.com> Co-authored-by: Alex Vuong <alex.vuong@salesforce.com>
* Fix pwless race conditions for all login places
…822712@) (#2785) * Remove call to withLegacyGetProps * Debugging * Revert change to AppConfig * Add todos * Try commenting out the problematic Chakra hooks Including those components that also call `useDisclosure`. * Revert "Try commenting out the problematic Chakra hooks" This reverts commit 970b97e. * Create a safe version of useDisclosure * Fix react-ssr-prepass lack of no-op for useInsertionEffect * Don't render Portal on server side * Show header again * Revert "Create a safe version of useDisclosure" This reverts commit 669f2eb. * This Portal is already rendered only on client side * Render nothing on server side * Clean up code * Remove unnecessary category check * Add comment * Update changelog files * Existing tests are now passing again * Revert change to the skeleton * Add a comment closer to the prepass call The setting of useInsertionEffect to a no-op had to be done in another file. * Create a safe version of Portal * Update changelog files * Add comments to clarify * Check first whether useInsertionEffect is defined or not * Add more tests to pass test coverage I didn't want to add test to react-rendering.test.js because my code change isn't much for testing. So I decided to add tests for another file instead. * Add comment
* init * Clean up styles * PR Feedback * Use zIndex value * Use zIndex default skipNav value * PR Feedback * Fix copyright year * Use token values instead of px * Move styles to base
* clean up and enable tests for all files
@W-18910676 Refactor product listing page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization